Re: [PATCH 1/2] dt-bindings: media: i2c: Add Sony IMX678

[Krzysztof Kozlowski]

On Wed, May 13, 2026 at 09:03:16PM +0530, Jai Luthra wrote:
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            oneOf:
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +                  - const: 4
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +                  - const: 4
> +                  - const: 5
> +                  - const: 6
> +                  - const: 7
> +                  - const: 8
> +
> +          link-frequencies: true

Drop. My patch fixing existing bindings is still valid and I do not
agree with other approach. I wanted to fix all existing bindings to make
it easier for you.

> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +
> +    required:
> +      - endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - avdd-supply
> +  - ovdd-supply
> +  - dvdd-supply
> +  - port
> +

Missing ref to video interface devices

> +additionalProperties: false

and this is unevaluated then

> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        camera@1a {
> +            compatible = "sony,imx678";
> +            reg = <0x1a>;
> +            clocks = <&imx678_clk>;
> +
> +            avdd-supply = <&camera_avdd_3v3>;
> +            ovdd-supply = <&camera_ovdd_1v8>;
> +            dvdd-supply = <&camera_dvdd_1v2>;
> +
> +            reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
> +
> +            port {
> +                imx678: endpoint {
> +                    remote-endpoint = <&cam>;
> +                    data-lanes = <1 2 3 4>;
> +                    link-frequencies = /bits/ 64 <720000000>;
> +                };
> +            };
> +        };
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2fb1c75afd16..5260cd83a255 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24911,6 +24911,13 @@ T:	git git://linuxtv.org/media.git
>  F:	Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
>  F:	drivers/media/i2c/imx415.c
>  
> +SONY IMX678 SENSOR DRIVER
> +M:	Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>
> +L:	linux-media@xxxxxxxxxxxxxxx
> +S:	Maintained
> +T:	git git://linuxtv.org/media.git

Drop. Individual drivers do not have dedicated trees. Media alrady
covers it.

Best regards,
Krzysztof