Re: [PATCH] crypto: Drop explicit assigment of 0 in pci_device_id array

From: Herbert Xu

Date: Fri May 15 2026 - 06:33:31 EST


On Mon, May 04, 2026 at 05:32:21PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Assigning .driver_data for drivers that don't use this struct member is
> just noise that can better be dropped. The same applies for an explicit
> zero in the terminating entry. Drop these.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> Hello,
>
> this is a preparing change for making struct pci_device_id::driver_data an
> anonymous union (similar to
> https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@xxxxxxxxxxxx/).
> This requires named initializers for .driver_data, but dropping unused
> assignments is still better and a nice cleanup on its own.
>
> Best regards
> Uwe
>
> drivers/crypto/cavium/cpt/cptvf_main.c | 4 ++--
> drivers/crypto/cavium/nitrox/nitrox_main.c | 4 ++--
> drivers/crypto/marvell/octeontx/otx_cptvf_main.c | 4 ++--
> drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 6 +++---
> 4 files changed, 9 insertions(+), 9 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt