Re: [PATCH] HID: lg-g15: Add support for the Logitech G710/G710+ gaming keyboards

[Hans de Goede]

Hi,

On 6-Apr-26 20:50, Hans de Goede wrote:
> Hi Xavier,
> 
> Thank you for your patch, it is always nice to have people helping
> with improving Linux support for devices like this.
> 
> On 2-Apr-26 09:52, Xavier Bestel wrote:
>> Add support for the Logitech G710 and G710+ (USB ID 046d:c24d) gaming
>> keyboards to the hid-lg-g15 driver.
>>
>> These keyboards have 6 G-keys (G1-G6), M-keys (M1-M3, MR), a game mode
>> toggle, and two independent backlights: one for the main keyboard and one
>> for the WASD keys, each with a physical button to cycle brightness through
>> 5 levels (0-4).
>>
>> Key implementation details:
>>
>>  - G-keys and M-keys are reported via HID input report 0x03 (4 bytes)
>>    using KEY_MACRO1-6, KEY_MACRO_PRESET1-3 and KEY_MACRO_RECORD_START.
>>
>>  - The WASD backlight LED is registered as
>>    "g15::kbd_zoned_backlight-wasd" rather than with a
>>    "::kbd_backlight" suffix, because UPower currently only supports a
>>    single kbd_backlight LED per device. This follows the nomenclature
>>    from Documentation/leds/leds-class.rst
> 
> Actually that nomenclature is something which was suggested in the past
> but has never been agreed upon.
> 
> Since the discussion about how to name the LED class devices for
> multi-zone keyboard backlights keeps coming up I've submitted a patch
> now to document how these should be named:
> 
> https://lore.kernel.org/linux-leds/20260406174638.320135-1-johannes.goede@xxxxxxxxxxxxxxxx/
> 
> Since the new userspace API for this needs to be agreed upon first, that
> patch should be accepted upstream first, before we can move forward with
> the G710 support from this patch.

My v2 patch with the LED naming scheme has been accepted into the
leds maintainer git tree now, so this is no longer a blocker for this
patch:

https://lore.kernel.org/linux-leds/20260504145434.12746-1-johannes.goede@xxxxxxxxxxxxxxxx/

Regards,

Hans