Re: [PATCH v2 1/3] dt-bindings: media: Add bindings for qcom,x1p42100-camss

[Wenmeng Liu]

On 5/14/2026 8:19 PM, Krzysztof Kozlowski wrote:
> On Mon, May 11, 2026 at 04:59:34PM +0800, Wenmeng Liu wrote:
> > Add bindings for the Camera Subsystem for X1P42100.
> >
> > The X1P42100 platform provides:
> > - 2 x CSIPHY
> > - 3 x TPG
> > - 3 x CSID
> > - 2 x CSID Lite
> > - 1 x IFE
> > - 2 x IFE Lite
> >
> > Signed-off-by: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>
>
> I do not see you responded to previous comments and FIRST one was not
> implemented, so I am ignoring the rest. Not going to review this.
>
> Best regards,
> Krzysztof

Hi Krzysztof,

Apologies for not clearly addressing your previous comments — that’s on me.

Regarding the first concern about dependencies: in v1 the series was 
indeed based on the csiphy rework, which pulled in a large set of 
dependencies from Bryan’s changes. In v2 I intentionally moved back to 
the existing (pre-rework) csiphy code to reduce the dependency 
footprint. As a result, the remaining dependencies are now limited to:
1) Clock changes (expected to be merged soon)
2) TPG support (planned to appear in linux-next shortly)
3) hamoa DTS

For the csiphy-related concerns you raised earlier, those should no 
longer apply with this approach since the series is no longer based on 
the reworked csiphy code.

Thanks a lot for your time and feedback.

Best regards,
Wenmeng