Re: [PATCH] mm/damon/core: clarify next_intervals_tune_sis update path

[SeongJae Park]

Hello nicheng,


On Fri, 15 May 2026 00:37:51 +0800 niecheng <niecheng1@xxxxxxxxxxxxx> wrote:

> damon_set_attrs() updates next_aggregation_sis and
> next_ops_update_sis for online attrs updates, but it does not update
> next_intervals_tune_sis there.
> 
> This can look like a missing update when reading damon_set_attrs()
> alone, while next_intervals_tune_sis is actually updated in
> kdamond_fn().
> 
> Add a short comment to make this explicit.

Thank you for making the code easier to read!

> 
> Suggested-by: SeongJae Park <sj@xxxxxxxxxx>
> Link: https://lore.kernel.org/linux-mm/20260514144102.120203-1-sj@xxxxxxxxxx/

So this is a second version of the patch on the above link, right?  From the
next time, please add the version on the subject prefix, e.g., [PATCH v2].
Also, from the next time,please post a new version of patches as new thread,
rather than a reply to the previous version, with the revision changelog with
the link to the previous version [1] on the commentary area.

> Signed-off-by: niecheng <niecheng1@xxxxxxxxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>

[1] https://docs.kernel.org/process/submitting-patches.html#commentary


Thanks,
SJ

[...]