Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
From: Dmitry Baryshkov
Date: Wed May 13 2026 - 08:09:40 EST
On Wed, May 13, 2026 at 01:59:19PM +0200, Neil Armstrong wrote:
> On 5/13/26 12:45, Dmitry Baryshkov wrote:
> > On Mon, May 11, 2026 at 11:20:31AM +0200, Neil Armstrong wrote:
> > > Add the necessary bits into the gen2 platforms tables and handlers
> > > to allow decoding streams into 10bit pixel formats.
> > >
> > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > > ---
> > > .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++++++++++++-
> > > drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
> > > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
> > > drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
> > > 4 files changed, 30 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> > > index 0541e02d7507..b6d815c01f1d 100644
> > > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> > > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> > > @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
> > > pixmp_ip->width = width;
> > > pixmp_ip->height = height;
> > > + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
> > > + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
> > > + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
> > > + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
> > > + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
> > > + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
> > > + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
> > > + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
> >
> > Do we support decoding of 10-bit videos to NV12 buffers?
>
> AFAIK no, I found no sign of that in the downstream driver but I may be wrong.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry