RE: [net-next v3 2/3] net: motorcomm: phy: set drive strength in YT8531s RGMII

[Minda Chen]

> 
> 
> 
> On 5/8/26 11:45, Minda Chen wrote:
> > Set RXD and RX CLK pin drive strength while in YT8531s connect with
> > RGMII.
> >
> > Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/net/phy/motorcomm.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
> > index c66804537aa2..ebc24f51e626 100644
> > --- a/drivers/net/phy/motorcomm.c
> > +++ b/drivers/net/phy/motorcomm.c
> > @@ -1698,6 +1698,11 @@ static int yt8521_config_init(struct phy_device
> *phydev)
> >   		if (ret < 0)
> >   			goto err_restore_page;
> >   	}
> > +
> > +	if (phydev->drv->phy_id == PHY_ID_YT8531S &&
> > +	    phy_interface_is_rgmii(phydev))
> > +		ret = yt8531_set_ds(phydev);
> 
> Minor detail if you re-spin, there's already a check for the interface being RGMII
> a bit above in the same function, but it's written as :
> 
> 
> 	/* set rgmii delay mode */
> 	if (phydev->interface != PHY_INTERFACE_MODE_SGMII)
>             ...
> 
> could be a good idea to change that check to a more explicit
> call to phy_interface_is_rgmii(), or even add the drive-strength
> configuration under the same block, provided the order of operation
> doesn't matter w.r.t the pll/auto-sleep configuration.
> 
> Maxime
> 
+	if (phydev->drv->phy_id == PHY_ID_YT8531S &&
    (phydev->interface != PHY_INTERFACE_MODE_SGMII)

 I just set it v1 like this.  This function is used by YT8521 and YT8531s，I don’t know whether YT8521 contains
RGMII pin drive strength setting . Maybe need Frank confirm it.  
 And Andrew's review comment is using  phy_interface_is_rgmii(phydev). 
> > +
> >   err_restore_page:
> >   	return phy_restore_page(phydev, old_page, ret);
> >   }