Re: [PATCH v2 04/10] iio: light: opt3001: use local struct device and i2c_client variables

[Andy Shevchenko]

On Tue, May 12, 2026 at 12:57:24PM +0200, Joshua Crofts via B4 Relay wrote:

> Switch the driver to use local variables for struct device and struct
> i2c_client to improve code style.
> 
> While at it, ensure that parentheses alignment is correct in functions
> that were changed in this patch.

> No functional change.

Right, but what I meant is to drop dev member from struct opt3001 completely
and derive it from client. Maybe it's done in the following patches? Haven't
seen them yet.

...

> +	dev_info(dev, "Found %c%c OPT%04x\n", manufacturer[0], manufacturer[1],
> +		 device_id);

Ideally this %c%c needs to be replaced with %2pE (this is not in the scope of
the patch, though).

-- 
With Best Regards,
Andy Shevchenko