Re: [PATCH net-next v5 5/5] net/sched: netem: add per-impairment extended statistics

[Stephen Hemminger]

On Sat,  9 May 2026 10:03:26 -0700
Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx> wrote:

> unters for each impairment netem applies (delay, loss,
> ECN marking, corruption, duplication, reordering) and for skb
> allocation failures during enqueue. Exposed through TCA_STATS_APP
> as struct tc_netem_xstats.
> 
> Counters increment when an impairment is occurs, independent of later
> events that may mask its on-wire effect. Added allocation_errors
> (similar to sch_fq) to account for when impairment could not be
> applied due to memory pressure, etc.
> 
> Signed-off-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> ---
> 
> Note to reviewers. The READ_ONCE/WRITE_ONCE pattern is to
> align with upcoming changes removing qdisc_lock.
> For some reason current AI prompts are obsessed with complaining
> about 64 bit torn read/write on these, since the counters are
> informational only, any such complaints are false positive.

The automated review comments on this patch are false positives.
Unfortunately, the review automation doesn't look at precedents
in other qdisc like RED, FQ, ...