Re: [PATCH v2 9/9] exfat: add support for SEEK_HOLE and SEEK_DATA in llseek

From: Namjae Jeon

Date: Tue May 12 2026 - 03:54:47 EST


On Tue, May 12, 2026 at 3:41 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> > } else {
> > + /*
> > + * valid_size is tracked in byte granularity and
> > + * marks the exact boundary between valid data and
> > + * holes (or unwritten space).
> > + *
> > + * When IOMAP_REPORT is set (used by lseek(SEEK_HOLE)
> > + * and SEEK_DATA), we return IOMAP_HOLE. This allows
> > + * iomap_seek_hole_iter() to directly return the
> > + * precise byte position.
> > + *
> > + * For normal I/O paths (without IOMAP_REPORT) we
> > + * return IOMAP_UNWRITTEN so the write path can
> > + * distinguish it from a real hole.
> > + */
>
> Ahhm this mostly has what I asked for earlier. But maybe also
> describe the IOMAP_F_ZERO_TAIL handling a bit above?
Okay, I'll add the comment for IOMAP_F_ZERO_TAIL.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks!
>