Re: [PATCH net-next v2 8/9] onsemi: s2500: Add driver support for TS2500 MAC-PHY

[Andrew Lunn]

> +static u32 phy_addr_list[S2500_NUM_REGS] = {
> +	(0x4 << 16) | 0x8000,

> +	(0xC << 16) | 0x10,

Is 4 OA_TC6_PHY_C45_VS_PLCA_MMS4?

0xC is your vendor 1?

These should probably be moved somewhere public:

#define OA_TC6_PHY_C45_PCS_MMS2                 2       /* MMD 3 */
#define OA_TC6_PHY_C45_PMA_PMD_MMS3             3       /* MMD 1 */
#define OA_TC6_PHY_C45_VS_PLCA_MMS4             4       /* MMD 31 */
#define OA_TC6_PHY_C45_AUTO_NEG_MMS5            5       /* MMD 7 */
#define OA_TC6_PHY_C45_POWER_UNIT_MMS6          6       /* MMD 13 */

and think about how you can represent 12 using a #define.

    Andrew