Re: [PATCH RESEND v2 0/5] hwmon: (pmbus/adm1266) blackbox, FW rev, rtc_class, GPIO label

[Guenter Roeck]

On 5/11/26 00:51, Abdurrahman Hussain wrote:
> This series fills in some gaps in the adm1266 driver and removes a
> probe-time RTC seed that was clobbering valid device state.
>
> Patch 1 exposes the firmware revision (IC_DEVICE_REV, 0xAE) via
> debugfs alongside the existing sequencer_state entry.
>
> Patch 2 adds a write-only clear_blackbox debugfs file. Devices
> configured for single-recording mode (BLACKBOX_CONFIG[0] = 0) need
> an explicit clear once the 32-record buffer fills; the documented
> sub-command ({0xFE, 0x00} block-write to 0xDE) wasn't reachable
> from userspace.
>
> Patch 3 exposes the non-volatile POWERUP_COUNTER (0xE4) via debugfs.
> The same value is embedded in every blackbox record, so the live
> value lets userspace match a captured record back to the boot it
> came from when correlating logs.
>
> Patch 4 replaces the probe-time SET_RTC seed with an rtc_class
> device backed by SET_RTC. The existing seed used CLOCK_MONOTONIC
> seconds, which is meaningless as a wall-clock time and clobbers
> whatever the device retained across a warm reboot. The data sheet
> (Rev. D, p. 22) explicitly recommends "frequently send the time
> stamp to the ADM1266 to synchronize the UNIX time and reduce the
> time from drifting" when running on the internal oscillator (no
> external 32.768 kHz crystal). Letting userspace own the policy via
> standard tooling (hwclock, chrony, systemd-timesyncd) against
> /dev/rtcN is both more correct and avoids any driver-specific
> sysfs ABI.
>
> Patch 5 disambiguates GPIO line labels on platforms that fit two
> ADM1266 devices on different I2C buses at the same slave address.
>
> Signed-off-by: Abdurrahman Hussain <abdurrahman@xxxxxxxxxx>
> ---
> Changes in v2:

And why the resend ?

Guenter