Re: [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages

From: Christoph Hellwig

Date: Mon May 11 2026 - 04:16:28 EST


On Fri, May 08, 2026 at 03:17:33PM +0530, Rohit Chavan wrote:
> Hi Christoph,
>
> Thank you for the feedback.
>
> My intent was to align the code with the standardized string helpers
> recently introduced in the kernel to reduce open-coding. However,
> I respect your preference for keeping the ternary form in the
> NVMe subsystem.

I guess it's more of a question for the people adding the helpers, but it
should also be in any place converting to it: what's the point?

The helpers don't reduce the code size, but increase cognitive load. Not
a good trade-off as far as I can tell, but maybe I'm missing something?