Re: [PATCH v3 2/2] mm/filemap: do not count FAULT_FLAG_TRIED retries as mmap hits

From: Vishal Moola

Date: Sun May 10 2026 - 08:52:24 EST


On Tue, Apr 28, 2026 at 01:59:44AM +0000, fujunjie wrote:
> A fault that starts synchronous mmap readahead can return VM_FAULT_RETRY
> after dropping mmap_lock. The retry may then map the folio brought in
> by that same miss.
>
> Do not let this retry decrement mmap_miss. The retry still maps the
> folio from the page cache; it just does not count as a useful mmap
> readahead hit.
>
> Signed-off-by: fujunjie <fujunjie1@xxxxxx>
> ---

Reviewed-by: Vishal Moola <vishal.moola@xxxxxxxxx>