Re: [PATCH v2 1/1] vfio: selftests: Find devices that have VFIO selftest drivers

[Josh Hilke]

On Fri, May 8, 2026 at 11:17 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> On Tue, Apr 14, 2026, Josh Hilke wrote:
> > +# Print the segment:bus:device.function numbers of PCI devices that can be used
> > +# to run VFIO selftests.
> > +function main() {
> > +     local vendor_device_id
> > +
> > +     for vendor_device_id in "${DEVICES[@]}"; do
> > +             lspci -D -d "${vendor_device_id}" | awk '{print $1}'
>
> For ignorant people like me, it would be helpful to capture what device was actually
> found.  I mean, I don't necessarily know exactly what these devices do, but as the
> list grows, at least having a general sense of what device I'm going to be feeding
> into VFIO would be helpful.
>

Sure I can do that.

> # ./devices.sh
> Intel SPR DSA (8086:0b25) Device IDs:
> 0000:6a:01.0
> 0000:6f:01.0
> 0000:74:01.0
> 0000:79:01.0
> 0000:e7:01.0
> 0000:ec:01.0
> 0000:f1:01.0
> 0000:f6:01.0

How about a "-v" (verbose) option which prints the device name
alongside the BDF?

$ ./list_devices.sh -v
0000:6a:01.0 Intel SPR DSA (8086:0b25)
0000:6f:01.0 Intel SPR DSA (8086:0b25)

This approach preserves the ability to pipe the script output into
/tools/testing/selftests/vfio/scripts/setup.sh to automate binding the
devices to VFIO by excluding the -v arg since the setup script expects
a list of BDFs.

> > +main "$@"
>
> Why pass along args?  The script doesn't actually recognize any arguments.

It's a remnant from copying another script when creating this one.
I'll remove it if we don't add the -v argument.