Re: [PATCH v5 01/13] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk

[Harshal Dev]

Hi Herbert, 

On 7 May 2026 3:50:21 pm IST, Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx> wrote:
>Hi Bjorn,
>
>On 5/5/2026 2:17 PM, Herbert Xu wrote:
>> On Thu, Apr 16, 2026 at 05:29:18PM +0530, Harshal Dev wrote:
>>> The DT bindings for inline-crypto engine do not specify the UFS_PHY_GDSC
>>> power-domain and iface clock. Without enabling the iface clock and the
>>> associated power-domain the ICE hardware cannot function correctly and
>>> leads to unclocked hardware accesses being observed during probe.
>>>
>>> Fix the DT bindings for inline-crypto engine to require the UFS_PHY_GDSC
>>> power-domain and iface clock for new devices (Eliza and Milos) introduced
>>> in the current release (7.1) with yet-to-stabilize ABI, while preserving
>>> backward compatibility for older devices.
>>>
>>> Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Document the Eliza ICE")
>>> Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: document the Milos ICE")
>>> Reviewed-by: Kuldeep Singh <kuldeep.singh@xxxxxxxxxxxxxxxx>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>>> Signed-off-by: Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx>
>>> ---
>>>  .../bindings/crypto/qcom,inline-crypto-engine.yaml | 35 +++++++++++++++++++++-
>>>  1 file changed, 34 insertions(+), 1 deletion(-)
>> 
>> Patch applied.  Thanks.
>
>Herbert has pulled out of picking this patch from his tree.
>As discussed, since this DT binding update relies on DTS changes in commits 12 and 13
>of these series, they should all go through the same tree.
>
>Can we aim to pick this series via the qcom-soc tree to ensure the binding and DTS changes
>are applied together? Since the 7.1 fixes window is open, I am hoping for this to be
>picked up this week or the next.
>

Can you please confirm for Bjorn once
that you're not picking this up and he
can pick it from his tree? 

Many thanks, 
Harshal

>Regards,
>Harshal
>