Re: [PATCH 2/2] x86/platform/geode: reference the real node of the cs5535 GPIO controller

[Dmitry Torokhov]

On Wed, Apr 29, 2026 at 02:23:31PM +0200, Bartosz Golaszewski wrote:
> We now can access the address of the software node associated with the
> GPIO controller cell of the cs5535 MFD device. Make it the target of the
> GPIO software node references in geode-common.c. Make sure the cs5535
> driver is built-in for all boards selecting GEODE_COMMON.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> ---
>  arch/x86/Kconfig                       | 10 +++++-----
>  arch/x86/platform/geode/geode-common.c | 12 +++++-------
>  2 files changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index f3f7cb01d69d022538d283f6c7049ba8bd4c3792..1b3cb3d92bdeb0e02f249e1b4801f06fb5fd8648 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -3072,7 +3072,7 @@ config GEODE_COMMON
>  
>  config ALIX
>  	bool "PCEngines ALIX System Support (LED setup)"
> -	select GPIOLIB
> +	depends on GPIO_CS5535=y

This is really too bad... Did you abandon the work to implement
notifiers to allow attaching nodes after gpiochip driver loads?

Thanks.

-- 
Dmitry