[PATCH v4] sched/psi: Skip CPUs with zero non-idle delta in per-CPU aggregation

[Zhan Xusheng]

collect_percpu_times() iterates over every possible CPU to build a
non-idle-weighted average of the PSI state times. When a CPU has
no PSI_NONIDLE delta for the current sampling interval:
  nonidle  = nsecs_to_jiffies(times[PSI_NONIDLE]) = 0
  deltas[s] += times[s] * nonidle               /* += 0 */

so the weighted accumulation contributes nothing.

get_recent_times() already sets the PSI_NONIDLE bit in
cpu_changed_states iff the PSI_NONIDLE delta is non-zero. Use that
bit to skip such CPUs early, as suggested by Johannes, avoiding the
nsecs_to_jiffies() call.

No functional change intended.

Suggested-by: Johannes Weiner <hannes@xxxxxxxxxxx>
Signed-off-by: Zhan Xusheng <zhanxusheng@xxxxxxxxxx>
---
v4:
 - Drop the incorrect Reviewed-by added in v2/v3; replace with
   Suggested-by. Johannes' "Makes sense." on v1 was an
   acknowledgement and an implementation suggestion, not a review
   tag.
 - Rebase commit message wording to describe "PSI_NONIDLE delta"
   rather than "non-idle jiffies", matching the actual check.
v3: https://lore.kernel.org/all/20260313034847.1422-1-zhanxusheng@xxxxxxxxxx/
 - Resend of v2.
v2: https://lore.kernel.org/all/20260204022328.23938-1-zhanxusheng@xxxxxxxxxx/
 - Use cpu_changed_states & (1 << PSI_NONIDLE) per Johannes'
   suggestion, saving the nsecs_to_jiffies() call.
v1: https://lore.kernel.org/all/20260203100007.22044-1-zhanxusheng@xxxxxxxxxx/
---
 kernel/sched/psi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index d9c9d9480a45..cd1174f0b5e5 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -384,6 +384,13 @@ static void collect_percpu_times(struct psi_group *group,
 
 		get_recent_times(group, cpu, aggregator, times,
 				&cpu_changed_states);
+		/*
+		 * If this CPU's PSI_NONIDLE delta is zero, it contributes
+		 * nothing to nonidle_total or to any deltas[] entry below,
+		 * so skip it early.
+		 */
+		if (!(cpu_changed_states & (1 << PSI_NONIDLE)))
+			continue;
 		changed_states |= cpu_changed_states;
 
 		nonidle = nsecs_to_jiffies(times[PSI_NONIDLE]);
-- 
2.43.0