Re: [PATCH v3] iio: light: stk3310: Deal with the ps interrupt issue in PM

[Jonathan Cameron]

On Wed, 29 Apr 2026 15:14:02 +0800
Miao Li <limiao870622@xxxxxxx> wrote:

> From: Miao Li <limiao@xxxxxxxxxx>
> 
> On the Inspur HS326 laptop(which integrated with HiSilicon M900
> processor), if the STK3311-X chip's PS interrupt is configured
> in "Recommended interrupt mode", the interrupt cannot be triggered
> normally after waking from suspend or hibernation.
> 
> In this case, neither disabling and re-enabling the interrupt nor
> resetting the PS threshold register can restore the interrupt to
> normal operation.
> 
> If the interrupt is disabled in suspend() then reset the PS threshold
> register and enable the interrupt in resume(). This resolves the issue.
> 
> Signed-off-by: Miao Li <limiao@xxxxxxxxxx>
Hi. 

Please do not send a new version in reply to an old one.  A few reasons
that most kernel maintainers ask for new threads for each version.

1. Threads can get very complex if there are lots of versions.
2. Many reviewers who find themselves with a few minutes look at most recent
   emails. In a threaded email client, a reply like this one ends up pages
   back so attracts fewer reviews.

I don't have anything else to add to Andy's review.  However please
slow down a bit on new versions to allow people to respond to earlier
ones.  If there is a known problem you have noticed after sending it
out feel free to review your own patch on the list and point that problem out.

Jonathan