Re: [PATCH v2 1/3] spi: microchip-core-qspi: control built-in cs manually

[Mark Brown]

On Tue, Apr 28, 2026 at 05:12:05PM +0100, Conor Dooley wrote:

> +static void mchp_coreqspi_set_cs(struct spi_device *spi, bool enable)
> +{
> +	struct mchp_coreqspi *qspi = spi_controller_get_devdata(spi->controller);
> +	u32 val;
> +
> +	val = readl(qspi->regs + REG_DIRECT_ACCESS);
> +
> +	val &= ~BIT(1);
> +	if (spi->mode & SPI_CS_HIGH)

The core already has handling for SPI_CS_HIGH, you shouldn't need to do
it in your driver.

Attachment: signature.asc
Description: PGP signature