Re: [PATCH 2/2] regulator: add SGM3804 Dual Output driver

[Mark Brown]

On Wed, Apr 29, 2026 at 09:37:49AM +0900, Mark Brown wrote:
> On Tue, Apr 28, 2026 at 03:52:06PM +0200, Neil Armstrong wrote:

> > +       ret = regulator_set_active_discharge_regmap(rdev,
> > +                                                   ctx->active_discharge[rdev_get_id(rdev)]);

> It seems like this should be a regcache sync then only the enable and
> disable operations need to be custom?  There is a register cache and it
> covers these registers, without it the _active_discharge wouldn't work
> since it does a regmap_update_bits() and all the registers are marked
> unreadable.

Actually I'm not clear how the cache works here since everything
writable is also marked as volatile but no register is readable.

Attachment: signature.asc
Description: PGP signature