Re: [PATCH] firmware: google: fix orphaned devices on partial populate failure

From: Julius Werner

Date: Tue Apr 28 2026 - 15:52:56 EST


> Given that, would the right approach be to continue the loop on
> entry-specific errors ( logging a warning), while still aborting and
> cleaning up on systemic ones like -ENOMEM? Or is the name collision
> case considered impossible here since names are derived from the
> tag/index and the table is only parsed once?

I don't think you should hardcode behavior so specific to what the
called function does. Trying every entry doesn't really hurt even if
they all fail due to some systemic problem, so if there's any chance
that other entries might succeed, I think the best option is to just
always continue the loop and try the next one.