Re: [PATCH v4 00/20] drm/tyr: firmware loading and MCU boot support

From: Alice Ryhl

Date: Tue Apr 28 2026 - 13:13:21 EST


On Tue, Apr 28, 2026 at 6:42 PM Deborah Brouwer
<deborah.brouwer@xxxxxxxxxxxxx> wrote:
>
> On Tue, Apr 28, 2026 at 10:56:17AM +0000, Alice Ryhl wrote:
> > On Mon, Apr 27, 2026 at 10:07:04AM +0200, Boris Brezillon wrote:
> > > On Fri, 24 Apr 2026 16:38:54 -0700
> > > Deborah Brouwer <deborah.brouwer@xxxxxxxxxxxxx> wrote:
> > > > Alvin Sun (1):
> > > > drm/tyr: use shmem GEM object type in TyrDrmDriver
> > > >
> > > > Beata Michalska (1):
> > > > drm/tyr: set DMA mask using GPU physical address
> > > >
> > > > Boris Brezillon (5):
> > > > drm/tyr: select required dependencies in Kconfig
> > > > drm/tyr: rename TyrObject to BoData
> > > > drm/tyr: Add generic slot manager
> > > > drm/tyr: add MMU module
> > > > drm/tyr: add GPU virtual memory module
> > > >
> > > > Daniel Almeida (1):
> > > > drm/tyr: add parser for firmware binary
> > > >
> > > > Deborah Brouwer (12):
> > > > drm/tyr: remove unused device from platform data
> > > > drm/tyr: move clock cleanup into Clocks Drop impl
> > > > drm/tyr: add shmem backing for GEM objects
> > > > drm/tyr: add a kernel buffer object
> > > > drm/tyr: add firmware loading and MCU boot support
> > > > drm/tyr: add Wait type for GPU events
> > > > drm/tyr: add Job IRQ handling
> > > > drm/tyr: wait for global interface readiness
> > > > drm/tyr: validate presence of CSF shared section
> > > > drm/tyr: add CSF firmware interface support
> > > > rust: time: add arch_timer_get_rate wrapper
> > > > drm/tyr: program CSF global interface
> > >
> > > This series starts to be quite big, and it seems new features have been
> > > added to v4 (interactions with the FW). I'd recommend that we extract
> > > the uncontroversial bits (I'd say patch 1-2, 4-7) or have them applied
> > > to drm-rust-next right away. I know it's tempting to add features
> > > between revisions, but the more you do that the longer it will take to
> > > get the foundation merged.
> >
> > How about I pick up patches 1, 3, 4, 5, 6, 7 for drm-rust-next now?
>
> Don't pick patch 1 because it depends on the Device Context series.
> The DRM device only because redundant once it's Registered, so we can't
> remove it yet.
>
> Patch 3: "drm/tyr: move clock cleanup into Clocks Drop impl" applies
> cleanly to drm-rust-next so that could go.
>
> Patches 4-7 need conflict resolution.
>
> How about I prepare a new series of stuff that could go in
> immediately and that will at least make this fw-boot series shorter?

That sounds good to me.

Alice