Re: [PATCH v2 2/4] wifi: ath: Use the unified QMI service ID instead of defining it locally

From: Jeff Johnson

Date: Tue Apr 28 2026 - 13:05:52 EST


On 3/19/2026 7:26 AM, Jeff Johnson wrote:
> On 3/16/2026 10:14 AM, Daniel Lezcano wrote:
>> Instead of defining a local macro with a custom name for the QMI
>> service identifier, use the one provided in qmi.h and remove the
>> locally defined macro.
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxxxxxxxx>
>
> Bjorn,
> Feel free to take this through your tree since I don't think it will conflict
> with anything in mine and it will take time for the definition to propagate
> back to my tree via the normal workflow (which I would prefer over merging the
> immutable branch).
>
> Acked-by: Jeff Johnson <jeff.johnson@xxxxxxxxxxxxxxxx>

Now NAK...

The definitions have now propagated back to my tree, so I'll now take this
patch through my tree.

/jeff