Re: [PATCH v3 3/5] staging: rtl8723bs: rtw_mlme: remove dead commented-out code

[Luka Gejak]

On Mon Apr 27, 2026 at 12:55 AM CEST, Salman Alghamdi wrote:
> Remove commented-out code and its related comments/notes.
>
> Signed-off-by: Salman Alghamdi <me@xxxxxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 15 ---------------
>  1 file changed, 15 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index cdc631464565..c8971c03704c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -758,9 +758,6 @@ void rtw_surveydone_event_callback(struct adapter	*adapter, u8 *pbuf)
>  					struct wlan_bssid_ex *pdev_network = &regs->dev_network;
>  					u8 *pibss = regs->dev_network.mac_address;
>  
> -					/* pmlmepriv->fw_state ^= _FW_UNDER_SURVEY;
> -					 * because don't set assoc_timer
> -					 */
>  					_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);
>  
>  					memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid,
> @@ -1721,12 +1718,8 @@ void rtw_dynamic_check_timer_handler(struct adapter *adapter)
>  
>  		should_enter_ps = traffic_status_watchdog(adapter, true);
>  		if (should_enter_ps) {
> -			/* rtw_lps_ctrl_wk_cmd(adapter, LPS_CTRL_ENTER, 1); */
>  			rtw_hal_dm_watchdog_in_lps(adapter);
>  		} else {
> -			/* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1)
> -			 * in traffic_status_watchdog()
> -			 */
>  		}

By removing these comments above you are leaving empty else block that 
should be removed.

>  
>  	} else {
> @@ -2265,19 +2258,11 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
>  	/*  1. Supported rates */
>  	/*  2. IE */
>  
> -	/* rtw_set_supported_rate(pdev_network->supported_rates,
> -	 * pregistrypriv->wireless_mode);  will be called in rtw_generate_ie
> -	 */
>  	sz = rtw_generate_ie(pregistrypriv);
>  
>  	pdev_network->ie_length = sz;
>  
>  	pdev_network->length = get_wlan_bssid_ex_sz((struct wlan_bssid_ex  *)pdev_network);
> -
> -	/* notes: translate ie_length & length after assign the
> -	 * length to cmdsz in createbss_cmd();
> -	 */
> -	/* pdev_network->ie_length = cpu_to_le32(sz); */
>  }
>  
>  /* the function is at passive_level */

Best regards,
Luka Gejak