Re: [PATCH v2 2/2] rust: alloc: fix `Vec::extend_with` SAFETY comment
From: Hsiu Che Yu
Date: Mon Apr 27 2026 - 00:03:31 EST
On Sun, Apr 26, 2026 at 03:10:12PM +0200, Miguel Ojeda wrote:
For this case it doesn't matter too much, but in general, when
something is a fix, we add a Fixes: tag (and in most cases Cc: stable@
to accompany it). That helps backporting (when needed), adds context
e.g. for reviewing (at times), etc.
I did miss the Fixes: tag — and what I hadn't thought about was that
these tags feed into the underlying tooling and workflows.
I'll make sure to include a Fixes: tag in fix-related commits going
forward (and will likely use one in the assert! patch coming up shortly)!
On Sun, Apr 26, 2026 at 03:10:12PM +0200, Miguel Ojeda wrote:
By the way, now that I was looking at `reserve()`, the assert in the
example there should probably use `>= 11` since there is already an
element, instead of `>= 10`. That could be another similar patch.
I'll go ahead and work on that. I was thinking of changing it to `>= v.len() + 10`, which might make the intent clearer. For this patch, should I include the Suggested-by:, Reported-by:,
and Fixes: tags?
Thanks,
Hsiu