Re: [PATCH 1/2] staging: rtl8723bs: correct logical continuation check in rtw_btcoex.c
From: Greg Kroah-Hartman
Date: Sun Apr 26 2026 - 23:55:44 EST
On Sat, Apr 04, 2026 at 12:03:09AM +0200, Linus Probert wrote:
> Corrects logical continuation placement in rtw_btcoex.c
> Discovered and verified with checkpatch.pl
>
> Signed-off-by: Linus Probert <linus.probert@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index 0191a943f0a4..caa757b8dc0a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -10,8 +10,8 @@
>
> void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
> {
> - if ((media_status == RT_MEDIA_CONNECT)
> - && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
> + if (media_status == RT_MEDIA_CONNECT &&
> + check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true) {
> rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
> }
>
> --
> 2.53.0
>
I hate this checkpatch "warning" as you now need to remember what the
order of operations is :(