[PATCH] media: vicodec: fix reference leak on failed device registration
From: Guangshuo Li
Date: Wed Apr 15 2026 - 11:27:39 EST
When platform_device_register() fails in vicodec_init(), the embedded
struct device in vicodec_pdev has already been initialized by
device_initialize(), but the failure path returns the error without
dropping the device reference for the current platform device:
vicodec_init()
-> platform_device_register(&vicodec_pdev)
-> device_initialize(&vicodec_pdev.dev)
-> setup_pdev_dma_masks(&vicodec_pdev)
-> platform_device_add(&vicodec_pdev)
This leads to a reference leak when platform_device_register() fails.
Fix this by calling platform_device_put() before returning the error.
The issue was identified by a static analysis tool I developed and
confirmed by manual review.
Fixes: 256bf813ba39f ("media: vicodec: add the virtual codec driver")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
---
drivers/media/test-drivers/vicodec/vicodec-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/test-drivers/vicodec/vicodec-core.c b/drivers/media/test-drivers/vicodec/vicodec-core.c
index 318e8330f16a..bf9a75feee93 100644
--- a/drivers/media/test-drivers/vicodec/vicodec-core.c
+++ b/drivers/media/test-drivers/vicodec/vicodec-core.c
@@ -2238,8 +2238,10 @@ static int __init vicodec_init(void)
int ret;
ret = platform_device_register(&vicodec_pdev);
- if (ret)
+ if (ret) {
+ platform_device_put(&vicodec_pdev);
return ret;
+ }
ret = platform_driver_register(&vicodec_pdrv);
if (ret)
--
2.43.0