Re: [PATCH v2 3/6] ASoC: renesas: fsi: Fix trigger stop ordering

[Bui Duc Phuc]

Hi Morimoto-san,

> This patch should appearing much earlier.
Thanks for your guidance.
I will reorder the patch series to place this fix earlier in the sequence.

Best regards,
Phuc

On Tue, Apr 14, 2026 at 7:28 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
>
>
> Hi
>
> > From: bui duc phuc <phucduc.bui@xxxxxxxxx>
> >
> > Reorder calls to execute fsi_stream_stop() before fsi_hw_shutdown().
> > This ensures that all register accesses are completed before the clock is
> > disabled, preventing the system hang observed on r8a7740.
> >
> > Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> > ---
>
> This patch should appearing much earlier.
>
> >  sound/soc/renesas/fsi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c
> > index 109e06b5f32d..9df3e91ac79c 100644
> > --- a/sound/soc/renesas/fsi.c
> > +++ b/sound/soc/renesas/fsi.c
> > @@ -1606,9 +1606,9 @@ static int fsi_dai_trigger(struct snd_pcm_substream *substream, int cmd,
> >                       ret = fsi_stream_transfer(io);
> >               break;
> >       case SNDRV_PCM_TRIGGER_STOP:
> > +             fsi_stream_stop(fsi, io);
> >               if (!ret)
> >                       ret = fsi_hw_shutdown(fsi, dai->dev);
> > -             fsi_stream_stop(fsi, io);
> >               fsi_stream_quit(fsi, io);
> >               break;
> >       }
> > --
> > 2.43.0
> >