Re: [PATCH 2/2] arm64: dts: qcom: msm8916-panasonic-eluga-u2: add initial device tree
From: Konrad Dybcio
Date: Wed Apr 15 2026 - 05:07:49 EST
On 4/14/26 8:44 PM, Lin, Meng-Bo wrote:
> Panasonic ELUGA U2 is a phone using the MSM8916 SoC released in 2015.
>
> Add a device tree for with initial support for:
>
> - GPIO keys
> - GPIO LEDs
> - pm8916-vibrator
> - SDHCI (internal and external storage)
> - USB Device Mode
> - UART
> - Regulators
>
> Signed-off-by: "Lin, Meng-Bo" <linmengbo06890@xxxxxxxxx>
> ---
[...]
> +&pm8916_resin {
> + linux,code = <KEY_VOLUMEDOWN>;
> + status = "okay";
nit: let's uniformly keep a \n before 'status' across the file
with Dmitry's comment taken care of:
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad