Re: [PATCH 1/2] dt-bindings: iio: dac: add support for Microchip MCP48FEB02 to MCP47FEB02
From: Conor Dooley
Date: Tue Apr 14 2026 - 11:37:12 EST
On Tue, Apr 14, 2026 at 01:39:32PM +0000, Ariana.Lazar@xxxxxxxxxxxxx wrote:
> Hi Conor,
>
> > >
> > > patternProperties:
> > > @@ -161,8 +222,7 @@ patternProperties:
> > > properties:
> > > reg:
> > > description: The channel number.
> > > - minItems: 1
> > > - maxItems: 8
> > > + maxItems: 1
> >
> > Why is this changing? Was it originally a mistake and what you wanted
> > was a max of 8 but only one entry?
> >
> > >
>
>
> Thank you for the review.
>
> It was a mistake I missed in the devicetree
> binding for the mcp47feb02 driver. The property contains a single
> integer representing the channel number (0-7), as you said.
>
> Should I send a fix for the mcp47feb02 binding first or can I continue
> to rewrite/split mcp47feb02 driver into the core module with I2C
> protocol file and include this binding fix there too?
Do it separately please with a fixes tag and all that jazz.
Attachment:
signature.asc
Description: PGP signature