Re: [PATCH v5 0/4] ti-ads7950: fix gpio handling and facelift

[Jonathan Cameron]

On Sun, 05 Apr 2026 21:39:22 -0700
Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

> The original reason for this series is to make sure ti_ads7950_get()
> returns result in range [0, 1] or a negative error code to comply with
> gpiolib requirement.
> 
> During review David noticed the fact that the function also clobbers
> gpio state. Fixing that lead to adding cleanups using guard() and devm.
> 
Applied to the testing branch of iio.git. I'll rebase that on rc1 once available.

Thanks for persisting with this. Indeed a nice facelift ;)

Jonathan

> ---
> Changes in v5:
> - replace mutex_init() with devm_mutex_init() (Bartosz)
> - Link to v4: https://patch.msgid.link/20260329-ti-ads7950-facelift-v4-0-c568c508c49a@xxxxxxxxx
> 
> Changes in v4:
> - rebased on top of latest next
> - dropped the 2 already applied patches
> - restored inadvertently removed mutex_init() (Andy)
> - stopped calling devm_regulator_get_enable_read_voltage() on ACPI
>   systems as it is guaranteed to fail (David, Jonathan)
> - removed call to spi_set_drvdata() since it is not needed anymore (David)
> - Link to v3: https://patch.msgid.link/20260305-ti-ads7950-facelift-v3-0-a23fdd1a079e@xxxxxxxxx
> 
> Changes in v3:
> 
> - Added "Fixes" tags
> - Picked up reviewed-by tags for #1 and #2
> - Dropped the conversion to "error" variables
> - Avoid using scoped_guard (per David)
> - directly return results of function calls at the end of function (David)
> - Split spi_sync() error handling into a new patxch (Andy)
> - Switch to using devm_regulator_get_enable_read_voltage() (David)
> 
> Changes in v2:
> 
> - style fixes in #1 (per David)
> - fix to not clobber state (#2, new)
> - #3 and #4 (new)
> 
> ---
> Dmitry Torokhov (4):
>       iio: adc: ti-ads7950: switch to using guard() notation
>       iio: adc: ti-ads7950: simplify check for spi_setup() failures
>       iio: adc: ti-ads7950: switch to using devm_regulator_get_enable_read_voltage()
>       iio: adc: ti-ads7950: complete conversion to using managed resources
> 
>  drivers/iio/adc/ti-ads7950.c | 197 ++++++++++++++-----------------------------
>  1 file changed, 64 insertions(+), 133 deletions(-)
> ---
> base-commit: 2febe6e6ee6e34c7754eff3c4d81aa7b0dcb7979
> change-id: 20260220-ti-ads7950-facelift-ad8b5390a654
> 
> Thanks.
>