Re: [PATCH v14] Subject: [PATCH v14] hwmon: (yogafan) Extend support to more Lenovo consumer models

[Rong Zhang]

Hi Guenter,

On Sat, 2026-04-11 at 08:56 -0700, Guenter Roeck wrote:
> On 4/11/26 07:31, Rong Zhang wrote:
> > Hi Sergio,
> > 
> > On Fri, 2026-04-10 at 22:14 +0200, Sergio Melas wrote:
> > > Hi Rong, Hi Guenter,
> > > 
> > > Thank you for the review and for pointing out the overlap with lenovo-wmi-other.
> > > 
> > > 1. WMI Coexistence and Bogus Fans
> > > I completely agree that double-reporting is suboptimal. I will
> > > implement a check in the probe function using
> > > wmi_has_guid(LENOVO_WMI_FAN_GUID). If the WMI interface is present,
> > > yogafan will return -ENODEV and yield to your driver. This ensures my
> > > driver only covers models where WMI reporting is unavailable.
> > > 
> > 
> > You may also want to add a module parameter to override the WMI GUID
> > check as some devices do not support the fan reporting/tuning interface
> > despite having the WMI GUIDs.
> > 
> 
> Please, no new module parameters. If there are devices not supporting this,
> add them to an exclude list. Or make sure that only devices supporting
> the functionality are instantiated in the first place.

Fine. I will no longer request for a module parameter then. Relying on
WMI GUID checks with an exclude list to determine if lenovo-wmi-other is
preferred over yogafan is OK for us.

BTW, I just noticed that thinkpad_acpi also provides fan reporting and
tuning support for some ThinkPad devices when I saw a patch on the pdx86
list. So, +CC ibm-acpi-devel, Henrique.

Thanks,
Rong

> 
> Thanks,
> Guenter