Re:Re: [RFC PATCH 0/2] rust: block: add a borrowed blk-mq timeout callback

[wenzhaoliao]

Hi Greg,


Thank you so much for taking the time to review this patch and for your valuable guidance.


To be completely honest, we do not have a specific driver use case for this feature at the moment. Our overarching goal is simply to learn the kernel development process and find ways to genuinely contribute to the Rust-for-Linux project. 


Recently, we submitted a patch that unfortunately duplicated existing work. In that thread, Andreas Hindborg kindly pointed us to a new task with this exact suggestion:


"If you really want to use your tokens to improve the kernel, I would suggest adding boolean parameter support to the Rust module parameter parser code."
(https://lore.kernel.org/rust-for-linux/20260216-rnull-v6-19-rc5-send-v1-0-de9a7af4b469@xxxxxxxxxx/)


We took this as a good "first issue" to familiarize ourselves with the Rust subsystem, and that is the sole reason we implemented it. 


Learning from you that module options are considered 1990's technology and do not fit the modern kernel model is a great lesson for us. If we misunderstood the maintainer's intention, or if pursuing this outdated mechanism goes against modern kernel design principles, we sincerely apologize for the noise and for any burden this has caused.


We are perfectly happy to drop this patch if this functionality is no longer desired in the modern kernel. We really just want to help improve the kernel, and we will try our best to sync with the maintainers to pick up tasks that are more aligned with current kernel standards (like sysfs/configfs) next time.


Best regards,
Wenzhao







发件人：Andreas Hindborg <a.hindborg@xxxxxxxxxx>
发送日期：2026-04-11 18:29:34
收件人：Wenzhao Liao <wenzhaoliao@xxxxxxxxxx>,Jens Axboe <axboe@xxxxxxxxx>,Miguel Ojeda <ojeda@xxxxxxxxxx>,linux-block@xxxxxxxxxxxxxxx,rust-for-linux@xxxxxxxxxxxxxxx
抄送人：Boqun Feng <boqun@xxxxxxxxxx>,Gary Guo <gary@xxxxxxxxxxx>,"Björn Roy Baron" <bjorn3_gh@xxxxxxxxxxxxxx>,Benno Lossin <lossin@xxxxxxxxxx>,Alice Ryhl <aliceryhl@xxxxxxxxxx>,Trevor Gross <tmgross@xxxxxxxxx>,Danilo Krummrich <dakr@xxxxxxxxxx>,linux-kernel@xxxxxxxxxxxxxxx
主题：Re: [RFC PATCH 0/2] rust: block: add a borrowed blk-mq timeout callback>Hi Wenzhao,
>
>"Wenzhao Liao" <wenzhaoliao@xxxxxxxxxx> writes:
>
>> This small RFC series fills a missing blk-mq callback in the Rust block
>> layer. Today, Rust block drivers cannot participate in request timeout
>> handling because the Rust blk-mq vtable hardcodes `timeout: None`.
>
>I already pointed you to [1] multiple times. Please make sure to read
>that patch series. The functionality you are submitting is already
>covered by that series.
>
>If you really want to use your tokens to improve the kernel, I would
>suggest adding boolean parameter support to the Rust module parameter
>parser code.
>
>Be sure to credit your LLM according to [2]. And please do instruct your
>agents to find related discussion on the mailing list, so we avoid
>solving the same problem over and over.
>
>Best regards,
>Andreas Hindborg
>
>
>[1] https://lore.kernel.org/rust-for-linux/20260216-rnull-v6-19-rc5-send-v1-0-de9a7af4b469@xxxxxxxxxx/
>[2] https://docs.kernel.org/process/coding-assistants.html
>
>