Re: [PATCH v3] nvme: expose TLS mode

[Chris Leech]

On Wed, Apr 08, 2026 at 06:19:56PM +0200, Daniel Wagner wrote:
> It is not possible to determine the active TLS mode from the
> presence or absence of sysfs attributes like tls_key,
> tls_configured_key, or dhchap_secret.
> 
> With the introduction of the concat mode and optional DH-CHAP
> authentication, different configurations can result in identical
> sysfs state. This makes user space detection unreliable.
> 
> Expose the TLS mode explicitly to allow user space to
> unambiguously identify the active configuration and avoid
> fragile heuristics in nvme-cli.
> 
> Signed-off-by: Daniel Wagner <wagi@xxxxxxxxxx>

Looks good, I look forward to 'nvme config --scan --dump' being able to
get these configurations correct.  Thanks Daniel.

Reviewed-by: Chris Leech <cleech@xxxxxxxxxx>