Re: [PATCH v2 00/16] perf arm64: Support data type profiling
From: Tengda Wu
Date: Fri Apr 10 2026 - 04:17:56 EST
On 2026/4/10 15:00, Namhyung Kim wrote:
> On Wed, Apr 08, 2026 at 07:35:22PM +0800, Tengda Wu wrote:
>> Hi Namhyung,
>>
>> Thank you for the feedback.
>> I have received your comments and will get back to this as soon as I can.
>
> Thanks, I've reviewed the instruction tracking part.
>
> Basically my concern is that you should invalidate unknown or unhandled
> cases so that it should strictly maintain the correct states of
> registers and stack slots. Otherwise it would contain many incorrect
> results.
>
> Also, please take a look at sashiko reviews which spotted many things.
>
> https://sashiko.dev/#/patchset/20260403094800.1418825-1-wutengda%40huaweicloud.com
>
> Thanks,
> Namhyung
Much appreciate the thorough review.
There is a lot of valuable input here. I will take some time to deep-dive into
each comment and ensure all concerns are properly addressed in V2.
Thanks,
Tengda