Re: [PATCH] ALSA: hda/realtek: Add quirk for CSL Unity BF24B

[Takashi Iwai]

On Thu, 09 Apr 2026 07:58:21 +0200,
Zhang Heng wrote:
> 
> hda-verb /dev/snd/hwC1D0 0x14 0xB 0x40
>  I think this command is meaningless, so it was not written.
> hda-verb [ALC662_device] 0x01 SET_GPIO_MASK 0x03
> hda-verb [ALC662_device] 0x01 SET_GPIO_DIRECTION 0x03
> hda-verb [ALC662_device] 0x01 SET_GPIO_DATA 0x03
> sleep 1
> hda-verb [ALC662_device] 0x01 SET_GPIO_DATA 0x01
> sleep 1
> hda-verb [ALC662_device] 0x01 SET_GPIO_DATA 0x02
> 
> 
> This user actually used these commands and the audio output was normal.
> 
> The last two commands clearly trigger the falling edge of gpio_data 0x03,
> Referring to these commands, my patch writing should be normal.

With your code, you're writing GPIO bits 0x03 3 times at each init or
resume call; at first in alc_auto_init_amp(), then toggling high and
low in the fixup.  So the first write is obviously superfluous.

You should be aware of this behavior although the impact is rather
small.


Takashi