Re: [PATCH 1/5] soc: renesas: r9a08g045-sysc: Move common code to a helper

[Geert Uytterhoeven]

Hi Claudiu,

On Fri, 3 Apr 2026 at 16:13, Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Move common code from rzg3s_regmap_{readable,writeable}_reg() to a
> helper and use it to avoid code duplication.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v7.2.

Unfortunately this increases generated code size by 40 bytes.  I tried
adding a "dev" parameter to rzg3s_regmap_readable_writeable_reg(), so
it can be used directly as rz_sysc_init_data.writeable_reg() callback,
but that didn't help. Oh well...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds