Re: [PATCH v7] staging: media: av7110: fix coding style

From: Andy Shevchenko

Date: Wed Apr 08 2026 - 07:28:31 EST


On Wed, Apr 08, 2026 at 10:33:28AM +0530, Chethan C wrote:
> Hi,
>
> Just a gentle ping on this patch.
>
> I wanted to check if there are any comments or changes needed from my side.
>
> Thanks for your time.

You need to:
- do not top-post!
- do not quote hundreds of lines just for this message!
- wait a bit more, we are almost at the merge window time, quite unlikely
somebody will take this right away
- the Subject should have "staging:" part to be dropped; all media patches
are started with "media: " even for the staging folder

Also note the formatting patches are lowest in the priority.
If you wish to provide a real contribution, try something else. For example,
one of the listed in [1]. It's not that your patch is bad or unwelcome, no,
this is about the change that does almost nothing to the driver that needs
more real work.

> On Sat, Mar 28, 2026 at 10:21 PM Chethan C <mail.chethanc@xxxxxxxxx> wrote:

> > Fix indentation and alignment issues reported by checkpatch.pl.
> >
> > Rename enums av7110_rec_play_state, av7110_type_rec_play_format,
> > and av7110_encoder_command to follow kernel naming style.
> >
> > Rename wssData and wssMode to wss_data and wss_mode to avoid
> > camelCase identifiers.

[1]: https://gist.github.com/andy-shev/a2cb1ee4767d6d2f5d20db53ecb9aabc

--
With Best Regards,
Andy Shevchenko