Re: [PATCH] drm/panthor: Fix kernel-doc warning in panthor_sched.c
From: Steven Price
Date: Wed Apr 08 2026 - 04:57:30 EST
On 05/04/2026 20:23, Yicong Hui wrote:
> Fix the following W=1 kerneldoc warnings by adding the missing parameter
> descriptions for @ptdev and @events in panthor_sched_report_fw_events()
> and @ptdev in panthor_sched_report_mmu_fault()
>
> Warning: drivers/gpu/drm/panthor/panthor_sched.c:1898 function parameter 'ptdev' not described in 'panthor_sched_report_fw_events'
> Warning: drivers/gpu/drm/panthor/panthor_sched.c:1898 function parameter 'events' not described in 'panthor_sched_report_fw_events'
> Warning: drivers/gpu/drm/panthor/panthor_sched.c:2783 function parameter 'ptdev' not described in 'panthor_sched_report_mmu_fault'
>
> Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
> Signed-off-by: Yicong Hui <yiconghui@xxxxxxxxx>
Reviewed-by: Steven Price <steven.price@xxxxxxx>
Thanks, I actually have a patch I've been meaning to send for this.
There's a few more kerneldoc issues in this file (documentation doesn't
get output but there's no warning) - I'll push this to drm-misc-next and
send a patch for the remaining issues.
Thanks,
Steve
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> index a70f1db0764e..2d6dc5db4148 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -1894,6 +1894,8 @@ static void process_fw_events_work(struct work_struct *work)
>
> /**
> * panthor_sched_report_fw_events() - Report FW events to the scheduler.
> + * @ptdev: Device.
> + * @events: Bitmask of pending FW events to report.
> */
> void panthor_sched_report_fw_events(struct panthor_device *ptdev, u32 events)
> {
> @@ -2779,6 +2781,7 @@ static void panthor_group_start(struct panthor_group *group)
>
> /**
> * panthor_sched_report_mmu_fault() - Report MMU faults to the scheduler.
> + * @ptdev: Device.
> */
> void panthor_sched_report_mmu_fault(struct panthor_device *ptdev)
> {