RE: [PATCH v10 00/22] media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers
From: Dayananda, Vivekananda
Date: Tue Apr 07 2026 - 23:52:31 EST
Hi Dumitru,
Thanks for spinning this series again. I was able to run it end-to-end on our bench (IMX219 → MAX96717 → MAX96724) with the deserializer using control-
channel port 1, and everything streamed as expected.
One thing I noticed while testing: in max96724_select_links() (max96724.c:889), we zero MAX96724_REG3 before we loop over the links, and only set the bits
that correspond to disabled links. That means every enabled link finishes with 00, so the priv->cc_port_cfg value we cached from maxim,control-channel-port
(0xAA for port 0, 0x55 for port 1) gets wiped the first time this helper runs. The side effect is that a board requesting port 0 in DT will keep the default
port 1 after any call to select_links(). If we seeded val with priv->cc_port_cfg (or wrote that value back after the loop) before writing to MAX96724_REG3,
we could preserve the DT-configured CC routing.
Vivek