Re: [PATCH v2] net: ena: Do not waste napi skb cache

[Shay Agroskin]

Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> writes:

> CAUTION: This email originated from outside of the 
> organization. Do not click links or open attachments unless you 
> can confirm the sender and know the content is safe.
>
>
>
> By profiling, discovered that ena device driver allocates skb by
> build_skb() and frees by napi_skb_cache_put(). Because the 
> driver
> does not use napi skb cache in allocation path, napi skb cache 
> is
> periodically filled and flushed. This is waste of napi skb 
> cache.
>
> As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> and napi_alloc_skb() when allocating skb.
>
> This patch was tested on aws a1.metal instance.
>
> [ jwiedmann.dev@xxxxxxxxx: Use napi_alloc_skb() instead of
>   netdev_alloc_skb_ip_align() to keep things consistent. ]
>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Thank you for this work

Acked-by: Shay Agroskin <shayagr@xxxxxxxxxx>