Re: [PATCH] dt-bindings: Fix property name typos in if/then schemas

[Frank Li]

On Wed, Oct 28, 2026 at 07:02:12AM -0500, Rob Herring (Arm) wrote:
> Property names within if/then schemas currently go unchecked whether
> they have a type defined or match what's in the top-level schema. Adding
> a check finds a number of instances of typos. The typos result in the
> schema having no effect on constraints.
>
> With this, fix the mediatek,vcodec-encoder 'clocks' count constraint
> exposed by the name correction.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/clock/qcom,kpss-gcc.yaml     |  2 +-
>  .../bindings/display/brcm,bcm2711-hdmi.yaml          |  2 +-
>  .../bindings/display/msm/dp-controller.yaml          |  2 +-
>  .../devicetree/bindings/display/msm/hdmi.yaml        |  4 ++--
>  Documentation/devicetree/bindings/dma/fsl,edma.yaml  |  2 +-
>  .../devicetree/bindings/gpio/loongson,ls-gpio.yaml   |  2 +-
>  .../bindings/iio/adc/amlogic,meson-saradc.yaml       |  2 +-
>  .../bindings/media/mediatek,vcodec-encoder.yaml      | 12 ++++--------
>  .../devicetree/bindings/media/samsung,s5p-mfc.yaml   |  2 +-
>  .../devicetree/bindings/pci/mediatek-pcie.yaml       | 12 ++++++------
>  10 files changed, 19 insertions(+), 23 deletions(-)

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,kpss-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,kpss-gcc.yaml
> index 88b7672123a0..ed347096df46 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,kpss-gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,kpss-gcc.yaml
> @@ -62,7 +62,7 @@ then:
>      - '#clock-cells'
>  else:
>    properties:
> -    clock: false
> +    clocks: false
>      clock-names: false
>      '#clock-cells': false
>
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> index c1cefd547391..fd4d598f6ff8 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> @@ -145,7 +145,7 @@ allOf:
>              - description: CEC stuck at low interrupt
>              - description: Hotplug connected interrupt
>              - description: Hotplug removed interrupt
> -        interrupts-names:
> +        interrupt-names:
>            items:
>              - const: cec-tx
>              - const: cec-rx
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 094a6383bb77..f72d1b354007 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -304,7 +304,7 @@ allOf:
>          clocks:
>            minItems: 6
>            maxItems: 6
> -        clocks-names:
> +        clock-names:
>            minItems: 6
>            maxItems: 6
>
> diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml b/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> index dfec6c3480f3..02d27ccad024 100644
> --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> @@ -113,7 +113,7 @@ allOf:
>              - const: core
>              - const: master_iface
>              - const: slave_iface
> -        core-vcc-supplies: false
> +        core-vcc-supply: false
>
>    - if:
>        properties:
> @@ -136,7 +136,7 @@ allOf:
>              - const: core
>              - const: alt_iface
>              - const: extp
> -        hdmi-mux-supplies: false
> +        hdmi-mux-supply: false
>
>    - if:
>        properties:
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index f609038e35ae..0260d177c7d0 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -172,7 +172,7 @@ allOf:
>              const: fsl,imx7ulp-edma
>      then:
>        properties:
> -        clock:
> +        clocks:
>            minItems: 2
>            maxItems: 2
>          clock-names:
> diff --git a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> index 69852444df23..07c8b233c6bd 100644
> --- a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> @@ -80,7 +80,7 @@ allOf:
>          - resets
>      else:
>        properties:
> -        "#interrupts-cells": false
> +        "#interrupt-cells": false
>          interrupt-controller: false
>          resets: false
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
> index 70ab4e140e71..535213ba0c5e 100644
> --- a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
> @@ -92,7 +92,7 @@ allOf:
>      else:
>        properties:
>          nvmem-cells: false
> -        mvmem-cel-names: false
> +        nvmem-cell-names: false
>          clocks:
>            minItems: 4
>          clock-names:
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index 4505e66876a2..52f471a070d5 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -110,19 +110,15 @@ allOf:
>
>      then:
>        properties:
> -        clock:
> -          items:
> -            minItems: 1
> -            maxItems: 1
> +        clocks:
> +          maxItems: 1
>          clock-names:
>            items:
>              - const: venc_lt_sel
>      else:
>        properties:
> -        clock:
> -          items:
> -            minItems: 1
> -            maxItems: 1
> +        clocks:
> +          maxItems: 1
>          clock-names:
>            items:
>              - const: venc_sel
> diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> index b46cc780703c..4488d5ca9b9c 100644
> --- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> +++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> @@ -174,7 +174,7 @@ allOf:
>              - const: mfc
>          iommus:
>            maxItems: 2
> -        iommus-names: false
> +        iommu-names: false
>
>  examples:
>    - |
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> index c009a7a52bc6..7c40361f95ec 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> @@ -127,7 +127,7 @@ allOf:
>          phy-names:
>            const: pcie-phy1
>
> -        power-domain: false
> +        power-domains: false
>
>        required:
>          - resets
> @@ -150,7 +150,7 @@ allOf:
>            minItems: 2
>            maxItems: 2
>
> -        reset: false
> +        resets: false
>
>          reset-names: false
>
> @@ -171,7 +171,7 @@ allOf:
>          clocks:
>            minItems: 6
>
> -        reset: false
> +        resets: false
>
>          reset-names: false
>
> @@ -193,7 +193,7 @@ allOf:
>          clocks:
>            minItems: 6
>
> -        reset: false
> +        resets: false
>
>          reset-names: false
>
> @@ -215,7 +215,7 @@ allOf:
>          clock-names:
>            maxItems: 1
>
> -        reset: false
> +        resets: false
>
>          reset-names: false
>
> @@ -223,7 +223,7 @@ allOf:
>
>          phy-names: false
>
> -        power-domain: false
> +        power-domains: false
>
>          mediatek,pbus-csr: false
>
> --
> 2.53.0
>
>