Re: [PATCH v2] drm/imagination: simplify pvr_fw_trace_seq_data
From: Alessio Belle
Date: Wed Oct 28 2026 - 08:11:52 EST
On Mon, 05 Oct 2026 12:41:27 -0700, Rosen Penev wrote:
> The trace buffer copy always has ROGUE_FW_TRACE_BUF_DEFAULT_SIZE_IN_DWORDS
> entries, so embed it in struct pvr_fw_trace_seq_data as a fixed-size
> array instead of allocating it separately. This removes one allocation
> and its error handling, and lets FORTIFY_SOURCE and UBSAN_BOUNDS see the
> real size of the buffer.
>
> At about 48KB, the struct needs an order-4 page allocation, which can
> fail under memory fragmentation. Allocate it with kvzalloc_obj() so it
> falls back to vmalloc in that case, and free it with kvfree().
>
> [...]
Applied to drm-misc-next, thanks!
[1/1] drm/imagination: simplify pvr_fw_trace_seq_data
commit: feaa32dc98090b2f45f7b6f179711a6640169c1a
Best regards,
--
Alessio Belle <alessio.belle@xxxxxxxxxx>