Re: [PATCH v9 04/12] x86/resctrl: Do not enable ERDT when Sub-NUMA Cluster is enabled

[Chen Yu]

Hi Reinette,

On Tue, Oct 27, 2026 at 09:16:35AM -0700, Reinette Chatre wrote:
> Hi Chenyu,
> 
> On 10/27/26 1:54 AM, Chen Yu wrote:
> > On Fri, Oct 23, 2026 at 04:54:04PM -0700, Reinette Chatre wrote:
> >> On 10/13/26 7:58 PM, Chen Yu wrote:
> 
> ...
> 
> >>> +__init void resctrl_arch_update_snc(void)
> >>> +{
> >>> +	snc_nodes_per_l3_cache = snc_get_config();
> >>> +}
> >>> +
> >>
> >> This looks unnecessary. Could all these references to snc_nodes_per_l3_cache be dropped
> >> from monitor.c?
> >> Definition of snc_nodes_per_l3_cache could be moved to core.c where it is
> >> initialized now and its initialization could just be open coded in get_rdt_resources().
> >>
> > 
> > Yes, I moved the definition of snc_nodes_per_l3_cache to core.c and initialize
> > it there, but we cannot move all references to snc_nodes_per_l3_cache out of monitor.c
> > for now because several places in monitor.c use it. After all, IMHO snc_nodes_per_l3_cache
> > was mainly introduced to deal with MBM.
> 
> Agreed. By "these references" I referred to the references in this patch, not _all_
> references. I do expect snc_nodes_per_l3_cache to be added to internal.h and that
> existing usages remain untouched. 
>

OK, extern int snc_nodes_per_l3_cache; is in internal.h now.

thanks,
Chenyu