Re: [PATCH v3 4/5] media: atomisp: queue: move circbuf types and helpers to queue_comm.h

[Andy Shevchenko]

On Tue, Oct 27, 2026 at 12:03:39PM +0000, Rareș-Mihai Vladu wrote:
> The remote queue code only needs the circbuf descriptor and element
> layouts plus five small descriptor helpers from the circbuf library.
> Move them into ia_css_queue_comm.h and include that header instead of
> the circbuf ones.
> 
> The descriptor and element layouts are shared with the SP firmware and
> are moved unchanged, including their static_asserts.
> 
> While at it, drop the OP___assert() NULL checks from the moved helpers,
> as every caller passes the address of a local variable, and convert the
> moved code to the kernel u8/u32 types and the usual function
> declaration style.

Yep, good one
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

Next step (after this series lands) is to move from this implementation of
the circular buffer to kFIFO or circbuf from kernel APIs.

-- 
With Best Regards,
Andy Shevchenko