Re: [PATCH v2] MIPS: c-r4k: Flush the cache error vector before writing it uncached

From: Imre Kaloz

Date: Mon Oct 26 2026 - 17:00:28 EST


On Mon, Oct 26, 2026, at 21:00, Maciej W. Rozycki wrote:

<snip>

> Hmm, I'd be tempted to call the hook flush_dcache_size() or suchlike for
> consistency with our existing nomenclature where "flush" stands for WB+INV
> and to signify that this function doesn't touch I$ (the *_range() suffix
> is already taken for interfaces using start/end rather than start/size for
> the boundaries), although our naming seems messy overall.
>
> Any other suggestions, anyone?

Fine with me. Unless someone has a better name, v3 will call the hook
flush_dcache_size()

<snip>
>> @@ -1743,14 +1743,15 @@ void r4k_cache_init(void)
>>
>> flush_icache_all = r4k_flush_icache_all;
>> flush_data_cache_page = r4k_flush_data_cache_page;
>> + cache_wback_inv = r4k_cache_wback_inv;
>
> Please update arch/mips/mm/c-r3k.c accordingly.

Will do.


Thanks,
Imre