Re: [PATCH v2 1/2] hwmon: (gpd-fan) Reset both fans to automatic on duo boards

[Guenter Roeck]

On Sat, Sep 26, 2026 at 04:11:20PM -0400, Alexei Solcanu wrote:
> From: Alexei Solcanu <alexei.solcanu@xxxxx>
> 
> On boards using gpd_duo_drvdata (GPD Duo, GPD Win 5), writing
> pwm1_enable=2 only returns the first fan to EC control. The second fan
> keeps its last manual duty cycle, e.g. full speed after pwm1=255, so a
> fan control tool that exits leaves it running at that speed.
> 
> gpd_duo_write_pwm() writes both fan registers (pwm_write and
> pwm_write + 1), but switching to automatic only clears pwm_write.
> Also clear pwm_write + 1, so both fans return to EC control.
> 
> Tested on a GPD Win 5 (G1618-05). Not tested on the GPD Duo.
> 
> Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
> Assisted-by: LLM
> Signed-off-by: Alexei Solcanu <alexei.solcanu@xxxxx>
> Reviewed-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>

Applied.

Thanks,
Guenter