Re: [PATCH v3 06/22] gpio: ljca: Drop unused assignment of auxiliary_device_id driver data

[Sakari Ailus]

Hi Uwe,

On Mon, Oct 26, 2026 at 05:28:17PM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> The driver explicitly sets the .driver_data member of struct
> auxiliary_device_id to zero without relying on that value. Drop this
> unused assignment.
> 
> This patch doesn't modify the compiled array, only its representation
> in source form benefits.
> 
> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> ---
>  drivers/gpio/gpio-ljca.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-ljca.c b/drivers/gpio/gpio-ljca.c
> index f32d1d237795..ad5dc9a3a119 100644
> --- a/drivers/gpio/gpio-ljca.c
> +++ b/drivers/gpio/gpio-ljca.c
> @@ -472,7 +472,7 @@ static void ljca_gpio_remove(struct auxiliary_device *auxdev)
>  }
>  
>  static const struct auxiliary_device_id ljca_gpio_id_table[] = {
> -	{ "usb_ljca.ljca-gpio", 0 },
> +	{ "usb_ljca.ljca-gpio" },

If there's going to be v4, how about moving to named initialisers while at
it?

>  	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(auxiliary, ljca_gpio_id_table);

-- 
Regards,

Sakari Ailus