Re: [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()
From: Dan Carpenter
Date: Mon Oct 26 2026 - 06:20:33 EST
On Mon, Oct 26, 2026 at 02:54:23PM +0530, himanshu bakshi wrote:
> From: Himanshu Bakshi <himanshu.bakshi478@xxxxxxxxx>
>
> The fbtft_init_dbg() macro is not being used, so delete it.
>
> Reviewed-by: Dan Carpenter error27@xxxxxxxxx
This is formatted incorrectly.
>
Don't add a blank line in the middle of the Tag block.
Tags are supposed to be in chronological order. So Acks come
after the S-o-by tag.
> Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@xxxxxxxxx>
> ---
No v2 text.
Please, wait a day between resends, even for small things.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter